Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[repo] Enable NuGetAudit #5784

Merged
merged 2 commits into from
Aug 15, 2024
Merged

[repo] Enable NuGetAudit #5784

merged 2 commits into from
Aug 15, 2024

Conversation

ysolomchenko
Copy link
Contributor

Fixes ##5755

Changes

Enable NuGetAudit

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
  • Unit tests added/updated
  • Appropriate CHANGELOG.md files updated for non-trivial changes
  • Changes in public API reviewed (if applicable)

@ysolomchenko ysolomchenko marked this pull request as ready for review August 13, 2024 09:02
@ysolomchenko ysolomchenko requested a review from a team August 13, 2024 09:02
@github-actions github-actions bot added the infra Infra work - CI/CD, code coverage, linters label Aug 13, 2024
@codecov Codecov
Copy link

codecov bot commented Aug 13, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.30%. Comparing base (6250307) to head (b01e17d).
Report is 291 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5784      +/-   ##
==========================================
+ Coverage   83.38%   86.30%   +2.91%     
==========================================
  Files         297      256      -41     
  Lines       12531    11140    -1391     
==========================================
- Hits        10449     9614     -835     
+ Misses       2082     1526     -556
Flag Coverage Δ
unittests ?
unittests-Project-Experimental 86.26% <ø> (?)
unittests-Project-Stable 86.26% <ø> (?)
unittests-Solution 86.24% <ø> (?)
unittests-UnstableCoreLibraries-Experimental 85.86% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 204 files with indirect coverage changes

CodeBlanch
CodeBlanch approved these changes Aug 13, 2024
View reviewed changes
Copy link
Member

@CodeBlanch CodeBlanch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CodeBlanch CodeBlanch merged commit 5a0b686 into open-telemetry:main Aug 15, 2024
52 checks passed
This was referenced Sep 3, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CodeBlanch CodeBlanch CodeBlanch approved these changes

@vishweshbankwar vishweshbankwar vishweshbankwar approved these changes

@rajkumar-rangaraj rajkumar-rangaraj rajkumar-rangaraj approved these changes

@cijothomas cijothomas cijothomas approved these changes

Assignees
No one assigned
Labels
infra Infra work - CI/CD, code coverage, linters
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ysolomchenko @cijothomas @rajkumar-rangaraj @vishweshbankwar @CodeBlanch